feat: add labels input to configure - #182
Open
NotFounds wants to merge 4 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: a614ab5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Author
|
@Andarist |
|
is this available yet???? |
Member
|
I think this would be better as a separate action that could label PRs based on the input. This way you could provide the output of this action to that labeling action and we could include an example like that in our docs. I don't see a strong reason to include this new input here when this is easily achievable through composition. |
Member
|
I've created a PR here that should help to solve this need through composition. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be cool to attach labels when the action creates a release PR.
For example, if we add a
releaselabel to PRs, we can find release PRs easily.I implemented
labelsinput.labelsallows input, and we can specify comma-separated labels(include space).e.g.
cf. https://github.com/NotFounds/changesets-monorepo/blob/d42f07d8b7def90913c71be14e9d69c8d3254876/.github/workflows/release.yml
I confirmed it works well in NotFounds/changesets-monorepo#5.
